Code review request: CR 7181995 NMT ON: NMT assertion failure assert(cur_vm->is_uncommit_record() || cur_vm->is_deallocation_record

Coleen Phillimore coleen.phillimore at
Tue Sep 11 14:24:39 PDT 2012


This looks good.  I'm a bit concerned that mem-snapshot.cpp knows a bit 
too much about the thread stacks and the stack guarding commits and 
uncommits but it seems okay.

Thanks for fixing this and sorry for the lack of warning that we were 
changing memory allocation so much.

On 9/11/2012 2:23 PM, Zhengyu Gu wrote:
> This is a pretty significant changes on how NMT deal with virtual 
> memory records. The old logic processed virtual memory records based 
> on memory address order, then sequence number, which was fault, since 
> virtual memory operations do not have to base on the ranges' base 
> addresses. The corrected logic is to process virtual memory records 
> purely based on the sequence number.
> CR:
> Webrev:
> The changes passed following tests:
>   - JPRT tests
>   - vm quick tests
>   - Parallel classloading tests
>   - nsk stress tests
>   - jck60 stress tests
>   - quick jdi tests
>   - quick jvmti tests
> Thanks,
> -Zhengyu

More information about the hotspot-dev mailing list