Please review fix for 7196681: NPG: Some JSR 292 tests crash in Windows exception handler
christian.thalinger at oracle.com
Tue Sep 11 17:21:13 PDT 2012
On Sep 11, 2012, at 4:38 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> How is this? I added some TODO's and will file an RFE to implement this. I tested -XX:+VerifyOops with sparc and x86.
In this file you use verify_method instead of verify_method_ptr.
> There were some verify_oop's removed in the permgen project that would be good to add back. I will add that to the RFE.
> On 9/11/2012 7:27 PM, Christian Thalinger wrote:
>> On Sep 11, 2012, at 1:51 PM, Coleen Phillimore<coleen.phillimore at oracle.com> wrote:
>>> Summary: There was a rogue os::breakpoint() call in log_dependency left over from the jsr292 merge. Also removed verify_oop() calls for metadata.
>>> Tested CallSiteTest on windows 64 where this os::breakpoint() actually sends a breakpoint signal.
>> Oops. It must be a left-over from the merge. Otherwise this looks good and I agree that empty verify methods would be nice.
>> -- Chris
>>> open webrev at http://cr.openjdk.java.net/~coleenp/7196681/
>>> bug link at http://bugs.sun.com/view_bug.do?bug_id=7196681
More information about the hotspot-dev