Request for review (XS): 7200470 KeepAliveClosure not needed in CodeCache::do_unloading
david.holmes at oracle.com
Tue Sep 25 05:26:55 PDT 2012
On 25/09/2012 9:59 PM, Bengt Rutisson wrote:
> Thanks, Stefan!
> I need one more review from an OpenJDK Reviewer. Any takers? It's a very
> small change and fast to review...
I'm curious as to why the "keep alive" is no longer needed. Makes me
wonder if the actual KeepAliveClosures still serve a purpose?
> On 2012-09-25 13:20, Stefan Karlsson wrote:
>> Looks good.
>> On 09/24/2012 02:05 PM, Bengt Rutisson wrote:
>>> Hi all,
>>> Could I have a couple of reviews for this small change to remove some
>>> unused code?
>>> We are passing around a closure but we never use it.
>>> Posting this on hotspot-dev since it is unclear to me if this is a
>>> GC, Compiler or Runtime related fix. I plan on pushing this through
More information about the hotspot-dev