RFR(S) : 8012337 : Change Whitebox implementation to make absence of method in Whitebox.class not fatal
igor.ignatyev at oracle.com
Thu Apr 18 14:01:18 PDT 2013
could someone with "reviewer" status look at that?
On 04/17/2013 05:56 PM, Igor Ignatyev wrote:
> Thank you for review.
> I have updated webrev:
> - added checking for exception class
> - added print warning on unexpected error
> Best regards,
> Igor Ignatyev
> On 04/17/2013 03:22 PM, Mikael Gerdin wrote:
>> On 2013-04-17 12:11, Igor Ignatyev wrote:
>>> Hi all,
>>> Please review patch.
>>> If there is some method that presences in native part of whitebox, but
>>> absences in java side, we get 'j.l.NoSuchMethodError' exception
>> The intended use of is of course that whitebox.cpp and WhiteBox.java are
>> in sync since they are in the same hg repository.
>> I understand that some feel that they need to copy WhiteBox to some
>> other test suite and I find this change acceptable but unfortunate.
>>> Batch registration of WB functions was replaced with one by one
>>> JPRT of sanity tests and tests that use WhiteBox: runtime/interned,
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8012337/webrev.00/
>> It's too bad that you need a shell script here but I don't see any way
>> around it.
>> I'm ok with you pushing this.
>>> jbs: https://jbs.oracle.com/bugs/browse/JDK-8012337
More information about the hotspot-dev