RFR: 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__"
yunda.mly at taobao.com
Fri Aug 23 02:13:05 PDT 2013
Peter & Kris
Thank both of you very much!
From: serviceability-dev-bounces at openjdk.java.net [mailto:serviceability-dev-bounces at openjdk.java.net] On Behalf Of Peter Allwin
Sent: Thursday, August 22, 2013 5:34 PM
To: Krystal Mok
Cc: serviceability-dev at openjdk.java.net; hotspot-dev
Subject: Re: RFR: 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__"
Thanks for the reminder, I added Yunda as a contributor.
Thanks everyone for your reviews!
On Aug 12, 2013, at 6:03 PM, Krystal Mok <rednaxelafx at gmail.com> wrote:
Looks good to me. Thank you!
I'd like to mention again that the getHandle -> getAddress change has been purposed by Yunda, which I mentioned in , too.
On Monday, August 12, 2013, A. Sundararajan wrote:
On Monday 12 August 2013 06:21 PM, Peter Allwin wrote:
This patch addresses several Nashorn compatibility issues with in sa.js and is a merge of my patch  and Kris' (kmo)  which were developed separately.
webrev: http://cr.openjdk.java.net/~allwin/8011888/webrev.01/ <http://cr.openjdk.java.net/%7Eallwin/8011888/webrev.01/>
 http://cr.openjdk.java.net/~allwin/8011888/webrev.00/ <http://cr.openjdk.java.net/%7Eallwin/8011888/webrev.00/>
More information about the hotspot-dev