RFR (XL): 8029940: PPC64 (part 122): C2 compiler port

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Dec 10 16:01:16 PST 2013

I don't see .ad file. Did you do 'hg add'?

assembler_ppc.inline.hpp:  coding style in Assembler::isel() and 
Assembler::isel_0(). Put if's body on separate line and use {}. 
Variables definitions and assignments should be on separate lines.

frame_ppc.cpp:  three variables are defined under #ifdef CC_INTERP but 
are used outside it.
sharedRuntime_ppc.cpp: has the same problem.

interpreter_ppc.cpp:  please, confirm that you need #ifdef CC_INTERP in 
InterpreterGenerator::generate_abstract_entry() - you removed it in 
other places in this file (except in 

register_definitions_ppc.cpp: why you need interp_masm_ppc_32.hpp? Just 

atomic_linux_ppc.inline.hpp and orderAccess_linux_ppc.inline.hpp: empty 
diffs. Is it only spacing changes?


On 12/10/13 3:21 PM, Lindenmaier, Goetz wrote:
> Hi,
> this change contains the ppc c2 compiler port.  The major
> contribution is obviously the .ad file.
> In addition, it contains a row of improvements in ppc
> code already used, and fixups left over after the ppc_-prefix
> removal.
> http://cr.openjdk.java.net/~goetz/webrevs/8029940-0-c2/
> The change touches only files of the ppc port.
> Please review and test this change.
> Please only push it after 219, as that's required to build
> this change.
> (You might like the rules we use for matching StrIndexOf)
> Best regards,
>    Goetz.

More information about the hotspot-dev mailing list