RFR (S): 8019517: PPC64 (part 102): cppInterpreter: implement G1 support

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jul 3 01:48:50 PDT 2013

Hi Chris, 

I removed the comment altogether.  The first line is nonsense, too.
And the  statement that the accessor does the memory ordering
is not necessary, either, especially as it's not documented with all
the other calls.

I updated the webrev.

Best regards,

-----Original Message-----
From: Christian Thalinger [mailto:christian.thalinger at oracle.com] 
Sent: Mittwoch, 3. Juli 2013 06:36
To: Lindenmaier, Goetz
Cc: 'hotspot-dev at openjdk.java.net'; 'ppc-aix-port-dev at openjdk.java.net'; 'Vladimir Kozlov'
Subject: Re: RFR (S): 8019517: PPC64 (part 102): cppInterpreter: implement G1 support

+          // G1GC port. Use accessor instead of storing manually.
+          // Takes care of write barriers internally and replaces the code above.
+          ((objArrayOopDesc *) arrObj)->obj_at_put(index, rhsObject);

The comment "replaces the code above" seems odd.  Should it be removed?

-- Chris

On Jul 2, 2013, at 4:40 PM, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

> Hi,
> we implemented support for G1 in the cppInterpreter.
> This is basically all done in the accessor routines, they
> just have to be called properly.
> http://cr.openjdk.java.net/~goetz/webrevs/8019518-cInter_g1/
> I would be happy if I could get a review on this change.
> Thanks and best regards,
>  Goetz.

More information about the hotspot-dev mailing list