RFR (M): 8019519: PPC64 (part 105): C interpreter: implement support for jvmti early return.

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jul 3 11:36:58 PDT 2013


Just styling notes. Could you add {} for bodies of handle_Pop_Frame: and 
handle_Early_Return: cases?
Also can you store THREAD->jvmti_thread_state() in local before the 
switch and use it in all those places?

Could you explain why you removed from common code 'handle_return:' ?

-      istate->set_return_kind((Bytecodes::Code)opcode);


On 7/3/13 3:24 AM, Lindenmaier, Goetz wrote:
> Hi,
> This change implements jvmti early return  and pop frame support
> in the cppInterpreter. To work properly, the corresponding properties in
> JvmtiManageCapabilities::init_onload_capabilities() must be enabled.
> We will add this in a later change.
> I would be happy about a review of this change:
> http://cr.openjdk.java.net/~goetz/webrevs/8019519-cInter_earlyRet/
> Best regards,
>    Goetz.

More information about the hotspot-dev mailing list