RFR (M): 8019519: PPC64 (part 105): C interpreter: implement support for jvmti early return.
goetz.lindenmaier at sap.com
Thu Jul 4 05:39:42 PDT 2013
pop_frame_in_process will be cleared when the frame manager calls
the interpreter loop again with the message popping_frame.
6953477 broke our pop_frame tests. I don't see though how pop_frame
could be tested with 6953477, as the capability is not set
if CC_INTERP is defined.
(I removed a ShouldNotReachHere in the updated change, that was
in the wrong patch of the port but belongs here.)
_return_kind is unused. In the updated webrev I also removed the
definition of the field.
I also fixed the syntax stuff.
This is the new webrev:
From: serguei.spitsyn at oracle.com [mailto:serguei.spitsyn at oracle.com]
Sent: Mittwoch, 3. Juli 2013 21:59
To: Lindenmaier, Goetz
Cc: 'hotspot-dev at openjdk.java.net'; 'ppc-aix-port-dev at openjdk.java.net'; Vladimir Kozlov
Subject: Re: RFR (M): 8019519: PPC64 (part 105): C interpreter: implement support for jvmti early return.
The fix looks good in general.
Thank you for doing this!
A couple of comments:
It looks like you have accidentally dropped the line:
What is the reason that the following lines are deleted? (the same as Vladimir already asked):
On 7/3/13 3:24 AM, Lindenmaier, Goetz wrote:
This change implements jvmti early return and pop frame support
in the cppInterpreter. To work properly, the corresponding properties in
JvmtiManageCapabilities::init_onload_capabilities() must be enabled.
We will add this in a later change.
I would be happy about a review of this change:
More information about the hotspot-dev