Review request for JDK-8019632: Method parameters are not copied in clone_with_new_data

Eric McCorkle eric.mccorkle at
Sun Jul 21 19:05:33 PDT 2013

I've written a test based on that one.  However, as it is in jdk/, it
will need to go into TL, which means it will need to wait until
propagation from hsx.

In any case, it succeeds, and I now have a clean ute (testlist aka.
everything) and jprt run.

Do I have a second for this change?

On 07/18/13 11:22, Coleen Phillmore wrote:
> Eric,
> This code change looks good.   For the related bug that didn't copy
> method annotations, I added test:
> jdk/test/java/lang/instrument/ Can you
> use this test to write a new one to the JDK that demonstrates this bug? 
> We've been adding these tests to the JDK because it has the support
> there and all the other tests are there.
> Thanks,
> Coleen
> On 7/18/2013 9:38 AM, Eric McCorkle wrote:
>> Realized I'd duplicated a comment.  It's been corrected.
>> On 07/17/13 23:06, Eric McCorkle wrote:
>>> Hello,
>>> Please review this patch, which updates clone_with_new_data to copy
>>> method parameter data.  This was missed in the initial implementation.
>>> I've gotten a JPRT run that failed only due to running out of memory on
>>> some tests, and I'll be doing my usual complete testlist run soon.
>>> The webrev is here:
>>> The bug report is here:
>>> Thanks,
>>> Eric

More information about the hotspot-dev mailing list