RFR: 8025661: Ill-formed -Xminf and -Xmaxf options values interpreted as 0

Bengt Rutisson bengt.rutisson at oracle.com
Thu Oct 3 04:43:19 PDT 2013

Hi Stefan,

Looks good!

One minor nit. In the test you use "NAN" as something that should not be 
parsed as a number. Maybe it would be clearer to use something that is 
clearly not related to numbers, such as "garbage" or "invalid input".


On 10/3/13 1:19 PM, Stefan Johansson wrote:
> Hi,
> Please review this fix for:
> https://bugs.openjdk.java.net/browse/JDK-8025661
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8025661/webrev.00/
> Summary:
> The parsing of -Xminf and -Xmaxf has been done with atof() which 
> doesn't detect errors. If using strtod() instead it's possible verify 
> whether the whole input was parsed or not.
> Also added a test to verify that we detect ill-formed input after the 
> change.
> Thanks,
> StefanJ

More information about the hotspot-dev mailing list