RFR: 8025661: Ill-formed -Xminf and -Xmaxf options values interpreted as 0
stefan.johansson at oracle.com
Thu Oct 3 05:07:45 PDT 2013
I see your point, updated webrev to use "INVALID" instead of "NAN":
On 2013-10-03 13:43, Bengt Rutisson wrote:
> Hi Stefan,
> Looks good!
> One minor nit. In the test you use "NAN" as something that should not
> be parsed as a number. Maybe it would be clearer to use something that
> is clearly not related to numbers, such as "garbage" or "invalid input".
> On 10/3/13 1:19 PM, Stefan Johansson wrote:
>> Please review this fix for:
>> The parsing of -Xminf and -Xmaxf has been done with atof() which
>> doesn't detect errors. If using strtod() instead it's possible verify
>> whether the whole input was parsed or not.
>> Also added a test to verify that we detect ill-formed input after the
More information about the hotspot-dev