RFR: JDK-8019540: licensee reports a JDK8 build failure after 8005849/8005008 fixes integrated.
staffan.larsen at oracle.com
Mon Oct 14 02:59:51 PDT 2013
Looks good! Of course, the proof is in building it.
I can sponsor the hotspot fix.
On 14 okt 2013, at 11:25, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> Please review the following changes, correcting the conditions for when to build certain parts of the servicability features. Instead of guarding them with the OPENJDK variable, they need to be conditioned on the existence of the source itself.
> In hotspot, this only fails on Windows. The linux makefiles already check on the existence of the source rather than if it's an OPENJDK build. This change makes windows do the same.
> In JDK, it fails on all platforms. There is already a configure variable, ENABLE_JFR, that seems to be set correctly for this case.
> I will need a sponsor to push this to hotspot if it passes review.
More information about the hotspot-dev