Test webrev review please: Re: RFR ASAP please: 8026365: Fix verifier for anonymous classes
karen.kinnear at oracle.com
Thu Oct 17 13:41:06 PDT 2013
No - I attached the file directly. I couldn't figure out how to get webrev to show a new file without
doing a commit. So I didn't use the webrev for review - but thanks for looking at it - because I
forgot to send the TEST.groups. If I understand correctly, we now need to add to that whenever adding
a test that needs the full jdk as this one does for the asm library.
That said - I had to change test/TEST.groups in order to run my test - because the test itself
doesn't exist and the new mechanism to split things based on profiles seems intolerant - i.e. it doesn't
just report a problem and continue - it stops dead in its tracks. I'm sure David H will be delighted to fix that.
On Oct 17, 2013, at 3:41 PM, Daniel D. Daugherty wrote:
> I'm guessing that you mean this webrev:
> > http://cr.openjdk.java.net/~acorn/8026365.test/webrev/
> This webrev is against the current T&L/hotspot version instead
> of the version that is being sync'ed down from JDK8.
> runtime/8026365/InvokeSpecialAnonTest.java is added to this list
> but is not included in the webrev.
> Why is runtime/6878713/Test6878713.sh deleted in this webrev?
> On 10/17/13 12:17 PM, Karen Kinnear wrote:
>> Added test (thanks to Robert Field). Please review:
>> On Oct 17, 2013, at 12:13 AM, Karen Kinnear wrote:
>>> Please review quickly:
>>> webrev: http://cr.openjdk.java.net/~acorn/8026365/webrev/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026365
>>> Verifier called is_reference_assignable, which called resolve_or_null, which was looking for
>>> the anonymous class in the system dictionary, where it is not. So this will allow more anonymous
>>> class cases to get through the verifier while still doing validity checking (but on the host class only,
>>> not on the anonymous class).
>>> Robert's new test: reduct (which he will check in as part of the lambda side of this change)
>>> in progress: vm.quick, java.lang, java.util, Nashorn
>>> p.s. Alejandro, Dan, Calvin - they want this in TL ASAP - should I check this directly into hotspot-master tomorrow?
>>> p.s. Vincente - can you grab this patch to test with Robert's changes please? I tested with the patches he
>>> had given me
More information about the hotspot-dev