Review Request (S) 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed
david.holmes at oracle.com
Wed Sep 11 20:58:31 PDT 2013
On 12/09/2013 1:54 PM, David Holmes wrote:
> Hi Dmitry,
> It seems odd that you install the new_method even if there was an
> exception. What if the new_method is not valid because of the exception ?
> Also once you've cleared the exception and returned false, the user has
> no information as to why this failed. I understand we don't want to hit
> the guarantee here, but it seems there is a hole in the error flow.
> On 12/09/2013 7:39 AM, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>> bug: http://bugs.sun.com/view_bug.do?bug_id=8017230
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8017230
>> Open webrev:
>> Handle pending exceptions instead of firing a guarantee() in the
>> JVMTI rewrite_cp_refs_in_method().
>> UTE tests - in progress: vm.quick-pcl.testlist with limited
>> Metaspace memory,
>> Jtreg java/lang/instrument
More information about the hotspot-dev