Review request: 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize

Thomas Schatzl thomas.schatzl at
Fri Sep 13 02:27:46 PDT 2013

Hi Stefan,

On Thu, 2013-09-12 at 17:18 +0200, Stefan Karlsson wrote:
> - Limit MetaspaceSize to MaxMetaspaceSize
> - Make sure we don't align down to 0.
> - jtreg test
> Note that this patch also adds/changes some functionality in the 
> OutputAnalyzer in test/testlibrary.

  I have some question about this code:

  90   if (MetaspaceSize < 256*K) {
  91     vm_exit_during_initialization("Too small initial Metaspace
  92   }

can this code still be hit, given that you always round up MetaspaceSize
to min_alignment(). It sounds more logical to test MaxMetaspaceSize for
that amount - and maybe even set (Max)MetaspaceSize to this value at
minimum. The code already does the changes due to alignment anyway.

Just a thought.


More information about the hotspot-dev mailing list