RFR: 8024718: Metaspace performance counters and memory pools should report the same data

David Holmes david.holmes at oracle.com
Fri Sep 13 04:07:28 PDT 2013

Hi Erik,

Just looking at the tests ...

Can you please add -XX:+UsePerfData to the @run lines of the new test.

Have you discussed the change to InputArguments.contains? If we have any 
args that are substrings of other args then this change will cause 
incorrect matching. Would it not be better to add a new function that 
checks the prefix rather than the whole arg?


On 13/09/2013 7:46 AM, Erik Helin wrote:
> Hi all,
> this patch fixes some issues with memory pools and the performance
> counter reporting slightly different numbers for metaspace. I've also
> updated two jtreg tests as well as added a new one to test the change.
> InputArguments.java in the testlibrary is updated as well.
> InputArguments.contains now takes a prefix as a parameter instead of the
> exact name of a flag. This makes it possible to check if a flag expecting
> a value has been set. For example, -XX:MaxMetaspaceSize=100m can be
> checked by running InputArguments.contains("-XX:MaxMetaspaceSize").
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8024718/webrev.00/
> Testing:
> - JPRT
> - hotspot/test/gc (including updated and new tests)
> Thanks,
> Erik

More information about the hotspot-dev mailing list