RFR: 6900441 PlatformEvent.park(millis) on Linux could still be affected by changes to the time-of-day clock

Aleksey Shipilev aleksey.shipilev at oracle.com
Fri Sep 13 10:49:46 PDT 2013

On 09/13/2013 09:03 PM, Daniel D. Daugherty wrote:
>> http://cr.openjdk.java.net/~dholmes/6900441/webrev.v4/
> I think you want to get some other eyes on this change. This is
> my fourth review and I'm not catching everything. Or I'm catching
> something, but not for exactly the right reasons.

(Granted, I have mediocre experience with Linux APIs).
Nothing pops out for me. Thumbs up.

 "++absTime->tv_sec;" bothers me. There seems to be no reason to not to
use post-increment rather than let the readers infer what is being
incremented, and if the precedence rules play dirty here.


More information about the hotspot-dev mailing list