RFR: 8024826: (s) : Remove alt-rt.jar, used by +AggressiveOps"
mike.duigou at oracle.com
Tue Sep 17 09:34:06 PDT 2013
On Sep 17 2013, at 00:21 , David Holmes wrote:
> Hi Mike,
> Looks like there is one test that knows it has to exercise the alt-rt.jar version:
> * @run main/othervm Clone
> * @run main/othervm -XX:+AggressiveOpts Clone
> but it's harmless to leave the second invocation.
I will remove it.
Since the +AggressiveOpts option remains it is still valid. A better general solution (that I hope someone is running) is to run the entire jtreg suite with +AggressiveOpts as an extra JDK option.
> I didn't see anything in JDK or hotspot regression tests that would be impacted.
> Once you are ready I will sponsor the hotspot patch for you through hotspot-rt.
> On 17/09/2013 12:37 PM, David Holmes wrote:
>> Reviewed both hotspot and jdk changes.
>> Thumbs up and good riddance! :)
>> How do you propose to handle the coordination of the push?
>> On 17/09/2013 10:16 AM, Mike Duigou wrote:
>>> Hello all;
>>> This is a cross-repo patch which disables building and enabling of the
>>> alt-rt.jar file. The alt-rt.jar file has been used with the
>>> -XX:+AggressiveOpts option (which will be remaining for other
>>> optimizations). This jar file formerly contained (closed-source)
>>> versions of several JDK classes which were optimized for very specific
>>> workloads. The implementations weren't generally applicable and in
>>> many cases induced performance drops. In particular since we will not
>>> be providing optimized implementations of the Java 8 streams API for
>>> the alternate versions of these classes the performance relative to
>>> the standard implementations would be poor.
>>> Over time we've (largely Alan Bateman) been trying to eliminate this
>>> difficult to support feature. With this changeset the alt-rt.jar
>>> feature is retired.
>>> Ideally I would like a reviewer for both the HotSpot and JDK repos
>>> (could be the same person).
More information about the hotspot-dev