[9] RFR(S): JDK-8039498: Add iterators to GrowableArray

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Apr 9 18:36:12 UTC 2014

Hi Tobias

Changes looks fine to me. I would only move initial pre-declaration of 2 
new templates after GenericGrowableArray definition and before 
GrowableArray template which uses them.


On 4/9/14 6:19 AM, Tobias Hartmann wrote:
> Hi,
> please review the following patch.
> *Problem:*
> The implementation of "JDK-8015774: Add support for multiple code heaps"
> needs to manage multiple code heaps in the code cache. They will be
> stored in a GrowableArray data structure. Frequent accesses to the array
> using indices make the code more unreadable and error prone and result
> in code duplication.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8039498
> *Solution:*
> To simplify the access to the code heaps, the GrowableArray is adapted
> to support STL-style iterators. Further, custom iterators allow to only
> iterate over elements that satisfy a given predicate. This helps to
> access only specific code heaps.
> Webrev: http://cr.openjdk.java.net/~anoll/8039498/webrev.01/
> *Tests:*
> JPRT with segmented code cache implementation (to be reviewed)
> Thanks,
> Tobias

More information about the hotspot-dev mailing list