Introduce umbrella header orderAccess.inline.hpp
christian.thalinger at oracle.com
Tue Apr 29 19:44:24 UTC 2014
Yes, please. Are you going to do the same for prefetch_*.inline.hpp? ;-)
On Apr 29, 2014, at 4:08 AM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com> wrote:
> I would like to contribute a change that introduces an umbrella header
> orderAccess.inline.hpp to avoid the long #ifdef TARGET_OS_ARCH cascades.
> There aren't too much of these, but that's because most files that
> require that include automagically include the files with the
> With the umbrella header the includes can be listed explicitly without
> having to add the #ifdef platform cascades everywhere.
> This follows the scheme that was applied to atomic.inline.hpp.
> Please tell me whether this change is acceptable, then I will open
> an appropriate bug and send a RFR. The webrev below isn't tested
> sufficiently yet.
> Preliminary webrev:
> The change would introduce the new file runtime/orderAccess.inline.hpp.
> Further this change adds includes of orderAccess.inline.hpp in all .cpp
> and .inline.hpp files where a method of OrderAccess declared 'inline' is
> Finally it moves methods calling inline methods of OrderAccess from
> g1CollectedHeap.hpp and thread.hpp to the corresponding .inline.hpp
> files and adds the necessary includes in files using the moved
> Still a lot of calls to inline methods of OrderAccess in .hpp
> files aren't preceded by an according include. But for these
> files an appropriate .inline.hpp file is missing:
> Best regards,
More information about the hotspot-dev