RFR(L): 8037816 : Fix for 8036122 breaks build with Xcode5/clang
david.r.chase at oracle.com
Wed Apr 30 18:31:58 UTC 2014
On 2014-04-30, at 1:37 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> On 4/30/14 4:47 AM, David Chase wrote:
>> On 2014-04-30, at 2:14 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>> Thank you for fixing vm_version files.
>>> In c1_LIR.cpp, c1_Runtime1.cpp, ciInstanceKlass.cpp, ciMetadata.cpp, ciObject.cpp not all 0x%" PRIxPTR were replaced by PTR_FORMAT.
>>> I see you kept a lot of '0x" PRIxPTR' instead of using INTPTR_FORMAT (or PTR_FORMAT) when printing (p2i) pointers. Why?
>>> Files c1_LIR.cpp, c1_Runtime1.cpp, ciInstanceKlass.cpp, ciMetadata.cpp, ciObject.cpp, markOop.cpp.
>> I'm reluctant to do that, since it changes the output, from 0xbeef to 0x0000beef or 0x000000000000beef.
>> Is that really acceptable?
> We are printing pointers, we do and should, I think, print all their bits. It is indication that a value in an output is a pointer. When we have bad bits I prefer to have all 0s shown: 0x00100001 instead of 0x100001. And bad pattern is usually repeated: 0xbeefbeef.
0xbeef was a good pattern (and for illustration of the change), that's why it was not repeated :-).
If nobody objects, I'll make those changes, then.
More information about the hotspot-dev