AARCH64: 8064611: Changes to HotSpot shared code
david.holmes at oracle.com
Wed Dec 10 12:24:03 UTC 2014
On 10/12/2014 10:07 PM, Andrew Haley wrote:
> On 12/10/2014 11:22 AM, David Holmes wrote:
>> On 28/11/2014 11:41 PM, Volker Simonis wrote:
>>> I think Goetz answered to the remaining questions a few days ago:
>>> but for some reason his mail doesn't appear in this mail thread.
>>> As he wrote, the release store into the card table in graphKit.cpp
>>> isn't needed and we've just removed in in our internal version a few
>>> weeks ago as well.
>> Has anyone from hotspot team confirmed that analysis? I haven't seen
>> anything to that effect and I'm wary of making this kind of change to
>> shared code.
> The change comes from Goetz; no-one from the HotSpot team knew why it
> was there, so they said "ask Goetz", and he said it was a mistake.
Got it - PPC64 added it, but it wasn't actually needed.
> And besides that, if this releasing store was really needed there
> would have to be MemBars for the ports which don't have store release
> instructions, but there are none.
> I am, of course, perfectly happy to leave it as ifndef(AARCH64), but
> this has been rejected.
More information about the hotspot-dev