AARCH64: 8064611: Changes to HotSpot shared code
aph at redhat.com
Wed Dec 10 12:12:05 UTC 2014
On 12/10/2014 11:34 AM, David Holmes wrote:
> On 10/12/2014 8:59 PM, Andrew Haley wrote:
> Won't the unconditional return for aarch64 cause unreachable code warnings?
Not for me, but I can add an else if you like.
> I'm not a C2 person but it seems strange to me that in one place if not
> using barriers for volatile you do nothing; whereas in the other place
> you insert Op_MemBarCPUOrder ??
That's a fair comment. Unfortunately C2 breaks if there are only CPU
barriers here, so I have to elide them in the back end. It is very
unfortunate, but there are many places where C2 makes assumptions
about the ideal graphs generated by the front end.
> Shouldn't UseBarriersForVolatile only be false on aarch64 ??
Oh gosh, however did I miss that? <red face>
More information about the hotspot-dev