AARCH64: 8064611: Changes to HotSpot shared code

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Dec 10 13:09:06 UTC 2014


yes, we verified that this release is not needed.  And it was introduced by us.

Best regards,

-----Original Message-----
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Andrew Haley
Sent: Mittwoch, 10. Dezember 2014 13:08
To: David Holmes; Volker Simonis; Vladimir Kozlov
Cc: ppc-aix-port-dev at openjdk.java.net; aarch64-port-dev at openjdk.java.net; hotspot-dev Source Developers
Subject: Re: AARCH64: 8064611: Changes to HotSpot shared code

On 12/10/2014 11:22 AM, David Holmes wrote:
> On 28/11/2014 11:41 PM, Volker Simonis wrote:
>> Hi,
>> I think Goetz answered to the remaining questions a few days ago:
>> http://mail.openjdk.java.net/pipermail/aarch64-port-dev/2014-November/001855.html
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-November/016199.html
>> but for some reason his mail doesn't appear in this mail thread.
>> As he wrote, the release store into the card table in graphKit.cpp
>> isn't needed and we've just removed in in our internal version a few
>> weeks ago as well.
> Has anyone from hotspot team confirmed that analysis? I haven't seen 
> anything to that effect and I'm wary of making this kind of change to 
> shared code.

The change comes from Goetz; no-one from the HotSpot team knew why it
was there, so they said "ask Goetz", and he said it was a mistake.
And besides that, if this releasing store was really needed there
would have to be MemBars for the ports which don't have store release
instructions, but there are none.

I am, of course, perfectly happy to leave it as ifndef(AARCH64), but
this has been rejected.


More information about the hotspot-dev mailing list