RFR(M): 8067941: [TESTBUG] Fix tests for OS with 64K page size.
goetz.lindenmaier at sap.com
Mon Dec 22 13:00:15 UTC 2014
Thanks for looking at this change!
> I would skip the entire test in that case (everything from the enclosing
> braces) instead of skipping only the actual test and not the setup.
I changed it accordingly. I had to move page_chunks out of the brackets, too.
From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com]
Sent: Montag, 22. Dezember 2014 13:01
To: Lindenmaier, Goetz
Cc: 'hotspot-dev at openjdk.java.net'
Subject: Re: RFR(M): 8067941: [TESTBUG] Fix tests for OS with 64K page size.
On Fri, 2014-12-19 at 16:05 +0000, Lindenmaier, Goetz wrote:
> please review this simple change. I please need a sponsor.
> The change should be downported to 8u60. It applies nicely except
> for some missing files.
> The issue is that we have linux ppc64 machines that have default page size
> of 64K. This imposes bigger limits on stack and heap sizes than if running
> with 4k pages.
> Ergonomics increase some flags if they are too small.
> Increasing the sizes used in the test slightly helps in most cases. Details:
> - Assertion in metaspace.cpp simly must fail with vm_page_size == 64K as it
> basically asserts vm_page_size < 16K
I would skip the entire test in that case (everything from the enclosing
braces) instead of skipping only the actual test and not the setup.
> - With 64K pages, heap sizes are computed differently starting from the alignment
> which is card_size * vm_page_size.
> Sizes are alinged up being equal in the end. Choose bigger sizes.
> Test computes some size based on the -Xmx value it uses. Heap size is increased slightly
> with 64K making the computation wrong and the test fail. Choose heap size that needs not
> be aligned.
> Heap of 10M is increased to 32M because of the alignment with 64K pages.
> This makes the evacuation succeed. Choose 32M from the beginning and adapt
> size of huge object.
More information about the hotspot-dev