RFR(M): 8034080 Remove the USDT1 dtrace code from Hotspot
david.holmes at oracle.com
Sun Feb 16 17:44:27 PST 2014
Indent is wrong here:
JNI_ENTRY(jobject, jni_NewGlobalRef(JNIEnv *env, jobject ref))
! HOTSPOT_JNI_NEWGLOBALREF_ENTRY(env, ref);
Is it worth renaming src/share/vm/utilities/dtrace_usdt2_disabled.hpp to
just src/share/vm/utilities/dtrace_disabled.hpp ? Or maybe even fold the
content back into dtrace.hpp
Otherwise looks good to see this all get stripped out!
On 11/02/2014 8:12 PM, Staffan Larsen wrote:
> Now that both the Solaris (JDK-8030812) and the Linux (JDK-8032462) implementations have moved to USDT2, we can finally remove the USDT1 code from hotspot.
> There are quite a lot of changes in this review, and webrev barfed on the number of change in jni.cpp so that file can only be reviewed from the patch file. The good news is that the changes are mostly trivial removal of #ifdef:ed code.
> bug: https://bugs.openjdk.java.net/browse/JDK-8034080
> webrev: http://cr.openjdk.java.net/~sla/8034080/webrev.00/
> Testing: I have run jck-runtime, vm.quick.testlist and vm.dtrace.testlist on Solaris and OS X.
More information about the hotspot-dev