RFR: 8035648: Don't use Handle in java_lang_String::print

Coleen Phillimore coleen.phillimore at oracle.com
Wed Feb 26 11:37:15 PST 2014

This looks fine.   It's a leaf function and it's pretty clear that there 
are no safepoints   In the past, we converted all the calls to take 
Handles whenever possible because it saved a lot of re-handleizing and 
bugs with unhandled oops, and we prefer that unless there's a good 
reason.   Here there is a good reason and it's obviously a leaf 
function, so this is fine.  I don't think you should add 


On 2/24/2014 4:44 AM, Stefan Karlsson wrote:
> Hi all,
> Please, review this change to let java_lang_String::print take a raw 
> String oop instead of a Handle to a String oop. This change makes 
> java_lang_String::print callable from code that has no HandleMark 
> setup. E.g. when calling from a debugger.
> Webrev:
> http://cr.openjdk.java.net/~stefank/8035648/webrev.00/
> RFE:
> https://bugs.openjdk.java.net/browse/JDK-8035648
> thanks,
> StefanK

More information about the hotspot-dev mailing list