RFR 8035735: Metaspace::contains become extremely slow in some cases
coleen.phillimore at oracle.com
Fri Feb 28 14:47:36 PST 2014
On 2/28/2014 5:03 PM, Daniel D. Daugherty wrote:
> On 2/28/14 1:08 PM, Coleen Phillimore wrote:
>> Summary: Call is_metadata instead which does less work for the call
>> in debugInfo.hpp which is called for all compiled code stack frames.
>> open webrev at http://cr.openjdk.java.net/~coleenp/8035735/
> line 276: // is_metadata is a faster check
> In the context of the current code review, the comment is fine,
> but when you read it down the road (by itself), you'll ask
> Faster than what? :-)
> // is_metadata() is a faster check than is_metaspace_object()
Thanks - you are right. I updated the comment.
Thank you for the code review.
> No comments.
> Thumbs up, modulo Jon M's question...
>> bug link https://bugs.openjdk.java.net/browse/JDK-8035735
>> Tested with failing test case, nsk.quick.testlist, jcks and jtreg tests.
More information about the hotspot-dev