RFR: 8046765: (s) disable FORTIFY_SOURCE for files with optimization disabled.
mike.duigou at oracle.com
Wed Jul 16 19:13:05 UTC 2014
On Jul 16 2014, at 12:02 , Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> No changes in make/linux/makefiles/ppc.make
That platform appears to use xlc rather than gcc in some case. I would need to be sure that whatever we changed there did not impact xlc compiles.
> Why next was removed from linux makefiles?:
> OPT_CFLAGS/compactingPermGenGen.o = -O1
The file appears to no longer exist. I assumed that it was removed as part of permgen removal.
> On 7/16/14 10:13 AM, Mike Duigou wrote:
>> Hello all;
>> In some GCC distributions the FORTIFY_SOURCE option is incompatible with the -O0. This change disables FORTIFY sources for the files we know have optimizations disabled.
>> jbsbug: https://bugs.openjdk.java.net/browse/JDK-8047952
>> webrev: http://cr.openjdk.java.net/~mduigou/JDK-8047952/0/webrev/
>> Unfortunately I don't have a Fedora 19 setup to test the change on the reported platform but I did verify that the compiler command line is correct, that fortify is disabled and the resulting build still works on a number of platforms. Additional verifications on other platforms is encouraged.
>> The changeset will be pushed via hotspot-rt forest unless otherwise requested.
More information about the hotspot-dev