RFR(S): 8050972: Concurrency problem in PcDesc cache
david.holmes at oracle.com
Fri Jul 18 10:05:49 UTC 2014
On 18/07/2014 7:08 PM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
> We fixed the comment and camel case stuff.
I'm not normally a fan of "documentary" comments but in this case I'm
okay with it :)
> We think it looks better if volatile is before the type.
> Best regards,
> Martin and Goetz.
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Donnerstag, 17. Juli 2014 17:52
> To: Doerr, Martin; Lindenmaier, Goetz; hotspot-dev at openjdk.java.net
> Subject: Re: RFR(S): 8050972: Concurrency problem in PcDesc cache
> First, comments needs to be fixed:
> "The array elements must be volatile" but in changeset comments: "// Array MUST be volatile!"
> Second, type name should be camel style (PcDescPtr).
> Someone have to double check this volatile declaration. Your example is more clear for me than typedef.
> On 7/17/14 8:19 AM, Doerr, Martin wrote:
>> Hi Vladimir,
>> the following line should also work:
>> PcDesc* volatile _pc_descs[cache_size];
>> But we thought that the typedef would improve readability.
>> The array elements must be volatile, not the PcDescs which are pointed to.
>> Best regards,
>> -----Original Message-----
>> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
>> Sent: Donnerstag, 17. Juli 2014 17:09
>> To: Lindenmaier, Goetz; hotspot-dev at openjdk.java.net
>> Subject: Re: RFR(S): 8050972: Concurrency problem in PcDesc cache
>> Hi Goetz,
>> What is the reason for new typedef?
>> On 7/17/14 1:54 AM, Lindenmaier, Goetz wrote:
>>> This webrev fixes an important concurrency issue in nmethod.
>>> Please review and test this change. I please need a sponsor.
>>> This should be fixed into 8u20, too.
>>> The entries of the PcDesc cache in nmethods are not declared as volatile, but they are accessed and modified by several threads concurrently. Some compilers (namely xlC 12 on AIX) duplicate some memory accesses to non-volatile fields. In this case, this has led to the situation that a thread had successfully matched a pc in the cache, but returned the reloaded value which was already overwritten by another thread.
>>> Best regards,
>>> Martin and Goetz.
More information about the hotspot-dev