RFR(S): 8050973: CMS/G1 GC: add missing Resource and Handle Mark

Thomas Schatzl thomas.schatzl at oracle.com
Mon Jul 21 08:54:32 UTC 2014


On Fri, 2014-07-18 at 12:47 +0000, Lindenmaier, Goetz wrote:
> Hi,
> This fixes two missing Resource and Handle marks.
> Please review and test this change.  We please need a sponsor
> to push it.
> http://cr.openjdk.java.net/~goetz/webrevs/8050973-mark/webrev-01/

I think the resource/handle marks should be added before the work method
is called for safety.

So I would prefer if the Marks were added to at least in the two places
in GangWorker::loop() and YieldingFlexibleGangWorker::loop() where the
work method is called, if not everywhere where work() is called.

The latter might be too big a change for now.

> Should this be pushed to 8u20?

Can you elaborate the consequences of not applying the patch to 8u20?
Only showstoppers can be pushed to 8u20 at this time, so we need a good

It seems to be a problem with ParallelRefProcEnabled only, and we have
not seen crashes.


More information about the hotspot-dev mailing list