AArch64 in JDK 9?
goetz.lindenmaier at sap.com
Tue Jul 22 14:33:56 UTC 2014
I had a look at your change.
It's really much less than what we adapted!
All the effort with the staging directory would be overkill I guess.
I tried to patch the change to hs-rt.
Unfortunately, my change cleaning up the shared includes of cpu files
was just pushed, so your change does not apply cleanly any more.
But in the end this should even more reduce the size of your patch.
I would add the includes in alphabetic sorting, i.e., before TARGET_ARCH_arm.
Same for lists of defines: c1_LIR.hpp:
+#if defined(SPARC) || defined(ARM) || defined(PPC) || defined(AARCH64)
I would put AARCH64 before ARM.
We also put AIX before BSD -- PPC was there already.
Saying that, why don't you reuse the includes etc. for ARM? In the end, only
the strings in os_linux must differ, and they could depend on ARM64 as we do
it for PPC.
In c1_LIR.c|hpp, I would use AARCH64 in defines instead of TARGET_ARCH_aarch64.
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Andrew Haley
Sent: Dienstag, 22. Juli 2014 12:08
To: Vladimir Kozlov; Volker Simonis
Cc: hotspot-dev Source Developers
Subject: Re: AArch64 in JDK 9?
I have prepared a diff that is the patch needed in the shared parts
of HotSpot for OpenJDK 9.
It is at http://cr.openjdk.java.net/~aph/aarch64.1
If it would help to have a webrev I will do that, but it wasn't
clear how it should be done.
I believe that there are no non-trivial changes to shared code which
are not guarded by TARGET_ARCH_aarch64, therefore it is unlikekly that
any other target will be affected. There are a couple of trivial
white space changes which I intend to remove; please ignore these.
I hope that this will help you estimate the work required on Oracle's
side to integrate this port.
More information about the hotspot-dev