RFR 8051398: jvmti tests fieldacc002, fieldmod002 fail in nightly with errors: (watch#0) wrong location

Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Jul 30 19:58:48 UTC 2014

On 7/30/14 1:20 PM, Coleen Phillimore wrote:
> Summary: Didn't handle NULL bcp for native methods
> bcp is set to NULL in the interpreter frame for native methods. x86 
> generate_native_entry() contains a call_VM that sets the bcp address 
> to the beginning of code, but sparc doesn't.  I don't think ppc does 
> either.   The code I changed, doesn't handle a null bcp which 
> post_field_access and post_field_modification tests call from JNI for 
> a native method.
> open webrev at http://cr.openjdk.java.net/~coleenp/8051398/

     I'm not seeing the reason for the code deletion here.
     Just re-read the bug and I'm still not seeing it.
     Could be that I've been away from this code for too long.

     line 652:   address bcp_from(address bci) const;
         Should the prototype parameter name be 'bcp' instead
         of 'bci' since the type is address?

     line 287:   if (is_native() && bcp == 0) {
     line 288:     return code_base() + (intptr_t)bcp;
         Why add '(intptr_t)bcp' since you know it is zero?

     No comments.


> bug link https://bugs.openjdk.java.net/browse/JDK-8051398
> Tested with jck vm/jvmti, jtreg, and NSK internal tests.  No test 
> added because there's a test that already tests this.
> Thanks,
> Coleen

More information about the hotspot-dev mailing list