RFR (M): 8035647 : PPC64: Support for elf v2 abi.

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Mar 6 18:50:05 UTC 2014


Please, run jcheck on your changes.

src/cpu/ppc/vm/cppInterpreter_ppc.cpp:1302: Tab character
src/cpu/ppc/vm/macroAssembler_ppc.hpp:322: Trailing whitespace
src/cpu/ppc/vm/stubGenerator_ppc.cpp:1708: Trailing whitespace

I will do clean up this time. But next time I will not accept such changes.


On 3/6/14 8:57 AM, Vladimir Kozlov wrote:
> Good, I will push it today.
> Thanks,
> Vladimir
> On 3/6/14 2:27 AM, Lindenmaier, Goetz wrote:
>> Hi,
>> I looked at the change and tested it on our linux ppc64 and on aix.
>> It's good.
>> I also tested it with the stage repo, that works fine, too.
>> Vladimir, can you push it to both, jdk9 and stage?
>> Sasha, I added parts of your Mail to the bug description:
>> https://bugs.openjdk.java.net/browse/JDK-8035647
>> Best regards,
>>    Goetz.
>> -----Original Message-----
>> From: ppc-aix-port-dev-bounces at openjdk.java.net
>> [mailto:ppc-aix-port-dev-bounces at openjdk.java.net] On Behalf Of
>> Vladimir Kozlov
>> Sent: Donnerstag, 6. März 2014 03:25
>> To: Alexander Smundak; hotspot-dev at openjdk.java.net
>> Cc: ppc-aix-port-dev at openjdk.java.net
>> Subject: Re: RFR (M): 8035647 : PPC64: Support for elf v2 abi.
>> Looks fine to me.
>> If ppc64 community is okay with this I can push it.
>> I saw discussion on ppc-aix alias but I need their comments on
>> hotspot-dev.
>> For Hotspot-dev, Alexander can contribute a code into open jdk because
>> he is under Google's umbrella 'Oracle Contribution Agreement'.
>> Thanks,
>> Vladimir
>> On 3/5/14 1:42 PM, Alexander Smundak wrote:
>>> This patch adds support for the recently introduced ELFv2 ABI
>>> for the PowerPC64.
>>> The patch was generated for the jdk9/hs-rt/hotspot repository
>>> (the same patch has been already committed to the ppc-aix-port/jdk7u).
>>> It should for to jdk8u via ppc-aix-port/stage.
>>> This patch is ppc-only.
>>> ELFv2 ABI has been introduced recently and is used on by Linux
>>> running on
>>> the little endian PowerPC64. There is no official ELF ABI supplement
>>> for it,
>>> but the differences with "old" ABI for PowerPC64 are explained in the
>>> comments for the patches to the GCC compiler:
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01144.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01141.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01140.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01145.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01147.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01149.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01146.html
>>> http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01150.html
>>> The change that affects JVM most is the elimination of the function
>>> descriptors (which unfortunately requires introducing a number of
>>> #ifdef's
>>> into the code), and dropping two words from the base frame (which
>>> required mostly renaming of the structs from `abi_48' to a more neutral
>>> `abi_minframe', etc.)
>>> There are additional patches needed to fully support building
>>> JDK on the little endian PowerPC64; RFRs for them will follow.
>>> The development was done on Ubuntu 14.04 running on QEMU.
>>> With all the patches applied, I can build working JDK7 and JDK9 there.
>>> Please review and test this change. I need a sponsor.
>>> The patch is at:
>>> http://cr.openjdk.java.net/~rasbold/8035647/webrev.00/
>>> Sasha

More information about the hotspot-dev mailing list