RFR (XS): 8037043: put Method flag bits in predictable positions
christian.thalinger at oracle.com
Tue Mar 11 21:23:37 UTC 2014
Thanks for the review, Coleen.
On Mar 11, 2014, at 1:49 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
> Ignore my other reply. This looks good. Thank you for adding the ()s.
> On 3/11/14 2:14 PM, Christian Thalinger wrote:
>> On Mar 11, 2014, at 7:37 AM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>>> No wonder you don't like C++ with code like that. Can you put () around the ?: expressions so I don't have to dig out my C++ manual to figure out order of operations in the getting and setting functions.
>>> On 3/10/14 8:44 PM, Christian Thalinger wrote:
>>>> 8037043: put Method flag bits in predictable positions
>>>> Currently Method flag bits are managed as a bit field which is C++ implementation specific. Sometimes we need to know the exact position of flag bits in its enclosing data type. For this reason other flag bits in HotSpot are implemented with enum shift values so the exact bit position can be easily identified.
More information about the hotspot-dev