RFR(XS) : 8038240 : new WB API to get nmethod
morris.meyer at oracle.com
Tue Mar 25 13:56:33 UTC 2014
I think the comments in WhiteBox.java, whitebox.cpp and whitebox.hpp
need to read 2012-2014 to be inclusive of changes from 2013.
Other than that this looks fine.
On 3/25/14, 5:06 AM, Igor Ignatyev wrote:
> Thanks for review, I've added a nmethod structure w/ code's array and
> compilation level. Since to use NMethod class directly in WhiteBox
> class, class should be added to bootclasspath, I decided to return the
> structure as an object array instead.
> I've replaced getMethodCompilationLevel in CompilerWhiteBoxTest and
> planning to remove this method completely in a separate CR.
> Also I've removed CLEAR_PENDING_EXCEPTION from CHECK_JNI_EXCEPTION macros
> On 03/25/2014 01:11 AM, Vladimir Kozlov wrote:
>> Can we pass a structure instead of code's array? We can add an
>> additional information about nmethod into such structure later if
>> needed. For now it would have just one pointer to jbyteArray array.
> On 03/25/2014 02:23 AM, Morris Meyer wrote:
>> Looks good. (Not a reviewer).
>> On 3/24/14 10:24 AM, Igor Ignatyev wrote:
>>> Hi all,
>>> Please review the patch which introduces a new WhiteBox method --
>>> getNMethod(). We need this method to write reliable tests for
>>> JDK-8031321 : 'Support Intel bit manipulation instructions'.
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8038240/webrev.00/
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8038240
>>> testing: jprt
More information about the hotspot-dev