RFR 8057696: java -version triggers assertion for slowdebug zero builds
sgehwolf at redhat.com
Mon Sep 8 16:43:12 UTC 2014
On Mon, 2014-09-08 at 11:01 -0400, Coleen Phillimore wrote:
> This looks good. I'll sponsor it. Thanks for contributing the patch.
Thank you, Coleen!
> On 9/5/14, 10:49 AM, Severin Gehwolf wrote:
> > Hi,
> > Can someone please review and sponsor this tiny change?
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8057696 (Thanks Omair for
> > filing it for me)
> > webrev:
> > https://fedorapeople.org/~jerboaa/bugs/openjdk/JDK-8057696/webrev.0/
> > As mentioned in the bug, the change as introduced with JDK-8003426
> > removed some Zero code in cppInterpreter_zero.cpp.
> > (AbstractInterpreterGenerator::generate_method_entry). In this code
> > block was an explicit call to generate_normal_entry() using a param
> > value of false unconditionally (regardless of synchronized == true or
> > not). After the JDK-8003426 change the generate_normal_entry() function
> > get's *correctly* called with true or false values. However, it renders
> > the assertion incorrect. The fix is to get rid of the offending
> > assertion.
> > Thanks,
> > Severin
More information about the hotspot-dev