RFR: 8058606 Detailed Native Memory Tracking (NMT) data is not output at VM exit
george.triantafillou at oracle.com
Tue Sep 30 14:06:19 UTC 2014
Thanks Lois, I've incorporated your suggested changes. I've also moved
the functionality of the test VerifyDetailSummaryOnExit.java to the
existing test PrintNMTStatistics.java.
After an offline discussion with Christian about how this change could
affect error reporting in vmError.cpp, I've run a more extensive set of
tests to verify the correct output when the VM crashes. You can take a
look at the changes here:
New webrev: http://cr.openjdk.java.net/~gtriantafill/8058606/webrev.01/
On 9/29/2014 9:17 AM, Lois Foltan wrote:
> Hi George,
> - I don't see where the variable mem_baseline is initialized
> before you invoke the method baseline()? I am not
> overly familiar with NMT but it looks like your might need to do
> something like: MemBaseline& baseline = MemTracker::get_baseline();
> - Your indentation for your edits at least in the webrev looks
> very off
> On 9/29/2014 7:55 AM, George Triantafillou wrote:
>> Please review this fix for JDK-8058606. The output from the
>> -XX:NativeMemoryTracking=detail option now outputs detailed tracking
>> information at VM exit. Previously, only summary tracking information
>> was output.
>> A new test was added to verify the output from both summary and
>> detail tracking options.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058606
>> Webrev: http://cr.openjdk.java.net/~gtriantafill/8058606/webrev/
>> <http://cr.openjdk.java.net/%7Egtriantafill/8058606/webrev/>The fix
>> was tested locally on Linux with jtreg and the JPRT hotspot testset.
More information about the hotspot-dev