RFR: 8076421: Fix Zero Interpreter bugs in class redefinition and template interpreter changeS

David Holmes david.holmes at oracle.com
Thu Apr 2 01:20:47 UTC 2015

Hi Coleen,

On 2/04/2015 2:41 AM, Coleen Phillimore wrote:
> Summary: metadata_do walking interpreted frames was wrong and
> generate_Reference_get is not necessarily an accessor method.
> Tested internal and test/runtime/RedefineTests with fix.   Also tested
> class redefinition tests with linux x64 since there were shared code
> changes.
> open webrev at http://cr.openjdk.java.net/~coleenp/8076421/
> bug link https://bugs.openjdk.java.net/browse/JDK-8076421

In frame.cpp:

-  if (_cb != NULL && Interpreter::contains(pc())) {
+  if (is_interpreted_frame()) {

Given most platforms (Zero being the exception!) define 
is_interpreted_frame() as Interpreter::contains(pc()) this change seems 
okay. But I do wonder what role if any _cb should be playing here and 
whether it can in fact be NULL?

Can't comment on Zero specifics.


> Thanks,
> Coleen

More information about the hotspot-dev mailing list