RFR; 8077420: Build failure with SS12u4

David Holmes david.holmes at oracle.com
Mon Apr 13 12:25:23 UTC 2015

Hi Stefan,

On 13/04/2015 9:57 PM, Stefan Karlsson wrote:
> Hi,
> Please review this fix for a build failure that was encountered during
> the Solaris Studio compiler upgrade.

So what was it about the compiler upgrade that exposed this ??

> Two files were missing an include of stack.inline.hpp, which is needed
> to get the definition of default_segment_size(). This function is used
> in the stack.hpp, to provide the default value to the constructor. This
> forces all users of Stacks with the default segment size, to have to
> include stack.inline.hpp. The default_segment_size() implementation
> always evaluates to the same value, given the template parameters, so I
> chose to setup a constant in the header instead of adding the missing
> stack.inline.hpp files.
> http://cr.openjdk.java.net/~stefank/8077420/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8077420

This seems okay but I have to say I remain very confused about the 
"right" way to deal with .hpp and .inline.hpp files in general.


> Tested with JPRT, and built with SS12u4.
> Thanks,
> StefanK

More information about the hotspot-dev mailing list