RFR(S): 8077618: Move rtmLocking.cpp to shared directory.
vladimir.kozlov at oracle.com
Tue Apr 14 02:09:28 UTC 2015
I updated copyright dates as David said and I submitted it to JPRT to
push since we have 2 reviews.
On 4/13/15 6:36 PM, David Holmes wrote:
> Hi Goetz,
> On 14/04/2015 1:57 AM, Lindenmaier, Goetz wrote:
>> we implemented support for Transactional Memory on ppc. For this, we
>> the file rtmLocking.cpp from subdirectory x86 as is.
>> Therefore I would like to move the file to share/vm/runtime, where the
>> corresponding header is placed. I added a guard around the code in
>> this file.
> Not sure if we need the guard in the cpp file - I guess it speeds up
> compilation a tiny amount :) If we do want it then the copyright date
> needs updating to "2014, 2015,".
>> Also, I moved #ifdef x86 from globalDefinitions.hpp to
>> which simplifies enabling RTM on PPC.
> Copyright date in src/cpu/x86/vm/globalDefinitions_x86.hpp needs updating.
>> Please review this change. I please need a sponsor.
> Otherwise looks okay.
>> Best regards,
More information about the hotspot-dev