RFR(XS): 8078243: Fix include of stack.inline.hpp in taskqueue.hpp.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Apr 21 09:45:03 UTC 2015

Hi Thomas,

I know what you are saying.  But for taskqueue this would be a major
reengineering, which should be done in a separate change.
It already includes memory/allocation.inline.hpp and runtime/orderAccess.inline.hpp.

This was broken by some previous cleanup, so I really would
appreciate this fix for now so that the aix build works again.

Best regards,

-----Original Message-----
From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com] 
Sent: Dienstag, 21. April 2015 11:23
To: Lindenmaier, Goetz
Cc: hotspot-dev at openjdk.java.net; hotspot-gc-dev at openjdk.java.net
Subject: Re: RFR(XS): 8078243: Fix include of stack.inline.hpp in taskqueue.hpp.

Hi Goetz,

On Tue, 2015-04-21 at 08:20 +0000, Lindenmaier, Goetz wrote:
> Hi,
> another include that’s missing.  This time it breaks aix only, would
> not have been 
> detected by non-pch build J
> taskqueue.hpp calls Stack::push(), thus it must include
> stack.inline.hpp.

.inline.hpp files should not be included by .hpp files because this
often causes lots of additional files to be included, and is prone to
creating include dependency cycles.

I think the only option here is to move the inline methods into their
own taskqueue.inline.hpp file that is included in the appropriate


More information about the hotspot-dev mailing list