RFR(L): 8077838: Recent developments for ppc.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Thu Apr 23 12:56:43 UTC 2015

Thanks fort he review, Volker!

I updated the webrev with your and Vladimir's proposals:

Best regards,

-----Original Message-----
From: Volker Simonis [mailto:volker.simonis at gmail.com] 
Sent: Donnerstag, 23. April 2015 14:34
To: Lindenmaier, Goetz
Cc: hotspot-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: Re: RFR(L): 8077838: Recent developments for ppc.

Hi Goetz,

this change is huge and not easy to review:)

So far I only found one mis-aligned comment in vm_version_ppc.cpp:

+  a->vand(VR0, VR0, VR0);                      // code[8]  -> vand
+  a->lqarx_unchecked(R7, R3_ARG1, R4_ARG2, 1); // code[9] -> lqarx_m
+  a->vcipher(VR0, VR1, VR2);                   // code[10] -> vcipher

Besides that, the change looks good.

Thanks for taking the effort to do this change!


On Wed, Apr 22, 2015 at 11:34 AM, Lindenmaier, Goetz
<goetz.lindenmaier at sap.com> wrote:
> Hi,
> this change contains recent changes in the ppc directory mostly made by SAP.
> It's a ppc-only change.
> http://cr.openjdk.java.net/~goetz/webrevs/8077838-ppc/webrev.01/
>  - Recognition of Power 8 processors (by Tiago Sturmer Daitx).
>  - Support for more new Power 8 instructions.
>  - Support for transactional memory. This is implemented but not yet tested
>    thoroughly due to limitiations of the OS support. Not enabled.
>  - java.lang.math.*Exact intrinsics
>  - Some C2 optimizations and fixes:
>    * Handling of flag registers. Some instructions would lead to uncompilable
>      methods due to not allocatable register patterns.
>    * Free some integer registers to use them for allocation. Handle compressed
>      oops base as constant.
>    * Unscaled class compression.
>  - Type profiling fixes.
> Please review this change.
> Best regards,
>   Goetz.

More information about the hotspot-dev mailing list