RFR: 8078621: AARCH64: Fails to build without precompiled headers

Andrew Haley aph at redhat.com
Mon Apr 27 07:50:22 UTC 2015


On 27/04/15 01:53, David Holmes wrote:

> On 25/04/2015 2:00 AM, Andrew Haley wrote:
>> http://cr.openjdk.java.net/~aph/8078621/
>   src/cpu/aarch64/vm/aarch64.ad
> This seems to be the only occurrence of a #include in a .ad file. If it 
> works I guess that is okay, but I don't know if it is intended to work.

I did consider that.  It's hard to know for sure, but the purpose of
that block is "definitions necessary in the rest of the architecture
description" so it logically makes sense there.  I suppose it could be
included in some other machine-dependent header file which is included
by aarch64.ad, but that feels to me like something of a kludge.

>   src/cpu/aarch64/vm/macroAssembler_aarch64.cpp
> I was wondering if the include of the opto headers should be guarded by 
> "#ifdef COMPILER2", but as the code that uses the definitions isn't also 
> guarded then I guess not.

I have my doubts about "#ifdef COMPILER2" in the back end.
I asked why the build didn't support client-only builds on 64-bit
systems and was told it's because the cost of supporting it wasn't
worthwhile; if we're never going to do client builds "#ifdef
COMPILER2" is mere clutter.  And of course, if client is never built
it will never be tested, so inevitably it'll rot.

> Copyright dates need updating before pushing.

Sorry, too late; it was already approved and pushed.



More information about the hotspot-dev mailing list