RFR(XS): [TESTBUG] Fix runtime/StackGuardPages/testme.sh to deal with 64k pages.
goetz.lindenmaier at sap.com
Mon Apr 27 13:13:08 UTC 2015
Yep, it's only 8k missing.
I added some more explanation to the bug.
From: David Holmes [mailto:david.holmes at oracle.com]
Sent: Montag, 27. April 2015 14:18
To: Lindenmaier, Goetz; hotspot-dev at openjdk.java.net
Subject: Re: RFR(XS): [TESTBUG] Fix runtime/StackGuardPages/testme.sh to deal with 64k pages.
On 27/04/2015 5:24 PM, Lindenmaier, Goetz wrote:
> Hi David,
> that's just because of the stack size computation in os_linux.cpp.
> It uses Linux::page_size, which is 64K, and Linux::vm_default_page_size(), which is 8K.
> Red/Yellow/Shadow pages are all set to 1.
> I already fixed a lot of jtreg tests wrt. the initial stack size.
> Best regards,
> oJ/8077838-ppc-hs-comp> output-jdk9-fastdebug/images/jdk/bin/java -Xss320K
> The stack size specified is too small, Specify at least 328k
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
Ah I see - just a case of minimal stack size being too small. Please add
this info to the bug report.
> -----Original Message-----
> From: David Holmes [mailto:david.holmes at oracle.com]
> Sent: Montag, 27. April 2015 02:38
> To: Lindenmaier, Goetz; hotspot-dev at openjdk.java.net
> Subject: Re: RFR(XS): [TESTBUG] Fix runtime/StackGuardPages/testme.sh to deal with 64k pages.
> Hi Goetz,
> On 24/04/2015 7:08 PM, Lindenmaier, Goetz wrote:
>> runtime/StackGuardPages/testme.sh fails on OSes with default 64K pages.
>> This happens on ppc linux distributions. The test passes -Xss320k to the VM.
>> Fix: increase to -Xss328K.
> Why does the test fail? I would have expected a stack size that is a
> multiple of possible page sizes (up to 64K) to be okay.
>> Please review this change of a single character ;) I please need a sponsor.
>> Best regards,
More information about the hotspot-dev