Review Request for JDK-8078112: Integrate Selection/Resolution test suite into jtreg tests
christian.tornqvist at oracle.com
Thu Apr 30 13:11:35 UTC 2015
Can you move all the common code into runtime/SelectionResolution/lib and add '@library lib' to the tests.
runtime/SelectionResolution/InvokeVirtualICCE.java also needs a longer timeout than the default 120s (took 142s to run on my fairly modern laptop), this can be done by changing the @run to '@run main/timeout=300 InvokeVirtualICCE'
Also, there's a significant performance issue when running these tests with a fastdebug/debug build (goes from 4min to 2h30m+), could you add code to skip running these on fastdebug/debug builds for now? You can use com.oracle.java.testlibrary.Platform.isDebugBuild() to accomplish this.
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Eric McCorkle
Sent: Friday, April 17, 2015 4:16 PM
To: hotspot-dev at openjdk.java.net
Subject: Review Request for JDK-8078112: Integrate Selection/Resolution test suite into jtreg tests
Please review this patch, which integrates a portion of the selection/resolution test suite into the JTreg test suite. This will integrate the tests in such a way that they are run on every integration.
This test suite uses a template-based generation scheme to exercise all aspects of the updated selection/resolution test suite from JVMS 8. It runs a very large number of tests, representing a very wide variety of cases. Extensive javadoc comments are found throughout the test code which describe the suite's functioning in more detail.
Note that the tests for abstract method error have been held back for further development.
Also note that this suite as already undergone extensive review as part of the development process.
The JBS issue is here:
The webrev is here:
More information about the hotspot-dev