RFR (M): 8112746: Followup to JDK-8059557 (JEP 245: Validate JVM Command-Line Flag Arguments)

Kim Barrett kim.barrett at oracle.com
Mon Aug 3 21:50:27 UTC 2015

On Aug 3, 2015, at 5:01 PM, sangheon.kim <sangheon.kim at oracle.com> wrote:
>> src/share/vm/runtime/commandLineFlagConstraintsGC.cpp
>>   53 static Flag::Error MinPLABSizeBounds(const char* name, bool verbose, size_t value) {
>>   66 static Flag::Error MaxPLABSizeBounds(const char* name, bool verbose, size_t value) {
>>   79 static Flag::Error MinMaxPLABSizeBounds(const char* name, bool verbose, size_t value) {
>>   86 Flag::Error YoungPLABSizeConstraintFunc(bool verbose, size_t value) {
>> Pre-existing issue:
>> While I'm all for using helper functions to break things up into
>> bite-sized chunks, in this case I think the helper functions are
>> actually making the code longer and more complicated.
> Actually 8078555 which is GC part flag implementation will utilize these helper functions for OldPLABSize, CMSOldPLABMin, CMSOldPLABMax.
> When I suggested '8130459: Add additional validation after heap creation', I mentioned that adding YoungPLABSizeConstraintFunc() as an example.

Ah, that explains it.  Thanks.

More information about the hotspot-dev mailing list