RFR (XXS): 8132969: C++11 requires a space between literal and identifier
christian.tornqvist at oracle.com
Tue Aug 4 13:44:19 UTC 2015
This looks good, thanks for fixing this. I can sponsor the change for you.
From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On Behalf Of Volker Simonis
Sent: Tuesday, August 4, 2015 9:41 AM
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: hotspot-dev at openjdk.java.net
Subject: RFR (XXS): 8132969: C++11 requires a space between literal and identifier
the change looks good. I've opened:
for it and created a webrev:
We still need a second reviewer who can sponsor the change.
On Mon, Aug 3, 2015 at 4:05 PM, Baesken, Matthias <matthias.baesken at sap.com> wrote:
> Hello, in
> "8081202 C++11 requires a space between literal and identifier", see
> a number of places in hotspot coding with missing spaces between literals and identifiers were already fixed.
> When experimenting with Visual Studio 2015 (which refuses compiling such code) , I noticed that this fix is missing here :
> The following small diff is fixing the remaining issue.
> < tty->print_cr("argument handler #%d at "PTR_FORMAT" for fingerprint " UINT64_FORMAT,
>> tty->print_cr("argument handler #%d at " PTR_FORMAT " for
>> fingerprint " UINT64_FORMAT,
> < tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: "PTR_FORMAT", new : "PTR_FORMAT")",
>> tty->print_cr("duplicate argument handler #%d for fingerprint "
>> UINT64_FORMAT "(old: " PTR_FORMAT ", new : " PTR_FORMAT ")",
> Could you please add the small fix ?
> Thanks, Matthias
More information about the hotspot-dev