RFR (S) 8144491 ElfSymbolTable::lookup returns bad value
stefan.karlsson at oracle.com
Wed Dec 2 16:48:16 UTC 2015
On 2015-12-02 15:30, Ioi Lam wrote:
> Please review a small fix:
> Bug: ElfSymbolTable::lookup returns bad value when the lookup has failed
> Summary of fix:
> I found this when trying to make disassembler.cpp print out more
> information for PrintInterpreter.
> The fix is straight-forward -- if the lookup fails,
> should return false.
> The only caller to ElfSymbolTable::lookup is ElfFile::decode(), so
> else would depend on the old (bad) behavior of
> I also took the chance to refactor lookup is ElfFile::decode() to
> split out
> two blocks of identical code into a new function,
The change looks correct. I would prefer if the refactoring was done as
a separate patch, but since this is Runtime code I'll let other
reviewers decide on that.
> RBT (hotspot/test/:hotspot_all) <-- what other tests should I run?
> - Ioi
More information about the hotspot-dev